fix(inputs.vault): Use http client to handle redirects correctly #14153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
powersj
approved these changes
Oct 23, 2023
powersj
pushed a commit
that referenced
this pull request
Oct 23, 2023
) (cherry picked from commit 56edee0)
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Mar 28, 2024
In influxdata#14153, the HTTP client config struct gained a response timeout config option with TOML tags. This meant that there were two defined for both Prometheus plugin and the HTTP client config struct. This removes the one in Prometheus, which was used to set the one in the HTTP client anyway. fixes: influxdata#15076
This was referenced Mar 28, 2024
sumo-drosiek
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Aug 22, 2024
…luxdata#14153) (cherry picked from commit 56edee0)
sumo-drosiek
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Aug 23, 2024
…luxdata#14153) (cherry picked from commit 56edee0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14138
This PR fixes handling of redirects from servers by switching the vault plugin to using
http.Clientinstead ofhttp.RoundTripper. While at it, we also use theplugins/common/httppackage for convenience adding morenice features like proxy support...
Additionally to the functional change, the PR adds an integration test and a http-redirect test mimicking the issue in #14138.