feat(outputs.wavefront): use common/http to configure http client

[LukeWinikates]

Required for all PRs

• Updated associated README.md.
• Wrote appropriate unit tests.
• Pull request title or commits are in conventional commit format

resolves #14090

This PR adopts Telegraf's common/http struct to configure the http.Client used by the Wavefront output plugin. This should be a harmonious way of exposing a variety of HTTP client customizations and tuning parameters, including the idle connection settings requested in #14909.

I removed existing fields for TLS and HTTP Timeout configuration, because the HTTPClientConfig exposes the same fields.

question: I am not sure if the init() function needs to set a default HTTPClientConfig.
note: this is currently using a branch of the Wavefront SDK. I want to get feedback on the PR early. Prior to final review, we (the Wavefront Go SDK maintainers) will release a new SDK version, and I will update this PR accordingly.

[srebhan]

Thanks for the nice upgrade @LukeWinikates! The code looks good, just two comments/requests from my side:

1. Please update to the github.com/wavefronthq/wavefront-sdk-go v0.14.1 package as soon as it is released. IIRC dependabot will not touch git-versions so we need to do this manually...
2. We now do have the possibility to include other configs in the sample.conf by creating a sample.conf.in and call the generator in the plugin file. Checkout the http input plugin for an example on TLS parameters... It would be nice if we could include those parameters here to present all options to the user... This can be a separate PR though!

[powersj]

Thank you! I do want to see the docs and sample config updated as a part of the final PR please.

I was not planning on landing given your comment about doing a final release of the client library. Do you still want to hold off?

Thanks again!

[LukeWinikates]

@srebhan @powersj thanks for the fast feedback!

@powersj yes, I would like to wait to merge this until we ship an updated Wavefront SDK release with the new configuration options exposed.

• I will get a new Wavefront SDK version released and update the PR with a proper released version
• I will update the docs and sample config.

I will circle back after that. Thanks again!

[LukeWinikates]

@srebhan @powersj just updated this branch to use the Wavefront SDK version released today, plus an update to the sample config.

Looking at @srebhan's comment about config file includes, I considered the possibility of extracting a config template that covers TLS options and idle connection settings, but I didn't take the plunge yet. The least complicated option would be to make a template that covers all of the httpconfig.HTTPClientConfig fields, using the content from the HTTP output plugin. Then everything that uses httpconfig.HTTPClientConfig could embed that too.

I like the idea of having a single source of truth about all the configuration options for httpconfig.HTTPClientConfig. I'd like to keep it out of scope for this PR.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[powersj]

Thank you!