chore: Fix linter findings for revive:exported in `plugins/inputs/l…

…*` (#16167)

internal/env.go

@@ -0,0 +1,19 @@
+package internal
+
+import "os"
+
+// GetProcPath returns the path stored in HOST_PROC env variable, or /proc if HOST_PROC has not been set.
+func GetProcPath() string {
+	if hostProc := os.Getenv("HOST_PROC"); hostProc != "" {
+		return hostProc
+	}
+	return "/proc"
+}
+
+// GetSysPath returns the path stored in HOST_SYS env variable, or /sys if HOST_SYS has not been set.
+func GetSysPath() string {
+	if hostSys := os.Getenv("HOST_SYS"); hostSys != "" {
+		return hostSys
+	}
+	return "/sys"
+}

plugins/inputs/bond/bond.go

@@ -11,19 +11,13 @@ import (
 	"strings"
 
 	"github.com/influxdata/telegraf"
+	"github.com/influxdata/telegraf/internal"
 	"github.com/influxdata/telegraf/plugins/inputs"
 )
 
 //go:embed sample.conf
 var sampleConfig string
 
-const (
-	defaultHostProc = "/proc"
-	defaultHostSys  = "/sys"
-	envProc         = "HOST_PROC"
-	envSys          = "HOST_SYS"
-)
-
 type Bond struct {
 	HostProc       string   `toml:"host_proc"`
 	HostSys        string   `toml:"host_sys"`
@@ -286,21 +280,11 @@ func (bond *Bond) gatherSlavePart(bondName, rawFile string, acc telegraf.Accumul
 // if it is empty then try read from env variable
 func (bond *Bond) loadPaths() {
 	if bond.HostProc == "" {
-		bond.HostProc = proc(envProc, defaultHostProc)
+		bond.HostProc = internal.GetProcPath()
 	}
 	if bond.HostSys == "" {
-		bond.HostSys = proc(envSys, defaultHostSys)
-	}
-}
-
-// proc can be used to read file paths from env
-func proc(env, path string) string {
-	// try to read full file path
-	if p := os.Getenv(env); p != "" {
-		return p
+		bond.HostSys = internal.GetSysPath()
 	}
-	// return default path
-	return path
 }
 
 func (bond *Bond) listInterfaces() ([]string, error) {

plugins/inputs/intel_baseband/sock_connector_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 
-	mocks "github.com/influxdata/telegraf/plugins/inputs/intel_baseband/mock"
+	"github.com/influxdata/telegraf/plugins/inputs/intel_baseband/mocks"
 )
 
 func TestWriteCommandToSocket(t *testing.T) {