feat(inputs): clockface 4 updates #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChitlangeSahas
force-pushed
the
clockface-4-input_updates
branch
from
fc15c23 to
08689c5
Compare
ChitlangeSahas
requested review from
a team,
mavarius and
juliajames12
as code owners
wdoconnell
reviewed
Oct 26, 2022
| @@ -304,7 +304,7 @@ $dropdown-item--padding-v: $cf-space-2xs; | |||
| } | |||
|
|
|||
| .cf-dropdown-item.active:not(.cf-dropdown-item__disabled) { | |||
| background-color: $cf-martinique; | |||
| background-color: #2A2649; | |||
There was a problem hiding this comment.
Do we not have a color variable for this color?
There was a problem hiding this comment.
Design team will be sending it to me after this week, basically, i'll be going through and deleting old colors and adding new ones with their names, and I thought I can just address this then (i'll be doing a global hex search to replace any hard coded values)
wdoconnell
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note, the changes are going into a running master for Clockface 4
Closes #839
Closes #865
Inputs:
Toggle:
RangeSlider:
Slide toggles:
Radio Toggles
Changes
// Describe what you changed
Screenshots
// Add screenshots here if relevant
Checklist
Check all that apply