Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addings render security fixes #377

Merged
merged 1 commit into from
Oct 24, 2023
Merged

addings render security fixes #377

merged 1 commit into from
Oct 24, 2023

Conversation

iruzevic
Copy link
Member

Changed

  • render and renderPartial methods are now no longer able to call the php files outside of themes/plugin folders. This is a security measure to prevent the execution of arbitrary code.
  • render method can now call wrapper as a component name.

@iruzevic iruzevic requested a review from a team October 24, 2023 07:07
@iruzevic iruzevic self-assigned this Oct 24, 2023
@iruzevic iruzevic linked an issue Oct 24, 2023 that may be closed by this pull request
Make wrapper simpler to load as standalone component infinum/eightshift-frontend-libs#738
Closed
@iruzevic iruzevic merged commit 1aa2648 into develop Oct 24, 2023
5 of 7 checks passed
@iruzevic iruzevic deleted the feature/standalone-wrapper branch October 24, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kancijan kancijan kancijan approved these changes

@goranalkovic-infinum goranalkovic-infinum goranalkovic-infinum approved these changes

@iobrado iobrado iobrado approved these changes

Assignees

@iruzevic iruzevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make wrapper simpler to load as standalone component
4 participants
@iruzevic @iobrado @goranalkovic-infinum @kancijan