Feature/v2/local trigger #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonatanPlesko
approved these changes
Dec 18, 2024
| fi | ||
|
|
||
| # Get install files | ||
| git clone --quiet https://github.com/infinum/app-deploy-script.git --branch feature/v2/local-trigger .app_deploy_tmp |
There was a problem hiding this comment.
--branch feature/v2/local-trigger
You will not forget to remove this, right? 😄
Comment on lines
+28
to
+29
| cat /Users/jaco/Infinum/Infinum_projects/AppDeployScript/app-deploy-script/app-deploy.sh > /usr/local/bin/app-deploy | ||
| cp -a /Users/jaco/Infinum/Infinum_projects/AppDeployScript/app-deploy-script/sources/. /usr/local/bin/.app-deploy-sources/ |
There was a problem hiding this comment.
Should comment this out maybe? And maybe "sanitize" your local path 😄
| if [ ${environment} -le $((${#environments[@]} - 1)) -a ${environment} -ge 0 ]; then | ||
| environments_to_build+=("${environments[${environment}]}") | ||
| else | ||
| echo "Error: You chose wrong, young Jedi. This is the end of your path..." |
|
|
||
| if [ -e "./.deploy-options.sh" ]; then | ||
| echo "Options file already exists." | ||
| echo "If you continue, stored options will be overriden!" |
There was a problem hiding this comment.
Suggested change
| echo "If you continue, stored options will be overriden!" | |
| echo "If you continue, stored options will be overridden!" |
| echo | ||
| echo "[3] App Store" | ||
| echo "[3] App/Play Store" |
| echo | ||
| echo "[3] App Store" | ||
| echo "[3] App/Play Store" | ||
| echo | ||
| read -r -p "Enter number in square brackets: " target_selection |
There was a problem hiding this comment.
It might help to be a bit more descriptive and explain how you can put multiple numbers delimited by space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, you can find some changes and news.
Changes
sourcesfolder__on a "private" function name (redhat convention)deploy-options.sh(options defined per project) by making it more mobile-related (from iOS-oriented) and by adding the flag that defines the version of the tag format.New features
initcommand is added. Once the script is installed (existing install command), the developer should runapp-deploy initin the project's root, where the.deploy-options.shfile will be added. That's the only file the dev should edit.script_versionflag that defines whether the project uses the old v1 approach (script generating build number) or the new v2 approach (script creating trigger tag). If someone updates the script but leaves.deploy-options.shwithout this property, the script will fall back to v1—this ensures backward compatibility.Usage
Screen.Recording.2024-12-05.at.17.30.37.mov