Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace personal info for publishing with Infinum's info #84

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

KCeh
Copy link
Collaborator

@KCeh KCeh commented Sep 10, 2024

Summary

Publishing info should reflect that Infinum is developer/maintainer of library. That info is shown when fetching licences with tools like: https://github.com/mikepenz/AboutLibraries

Changes

In all publish.gradle files personal info has been replaced with Infinum's info

Type

  • Feature: This pull request introduces a new feature.
  • Bug fix: This pull request fixes a bug.
  • Refactor: This pull request refactors existing code.
  • Documentation: This pull request updates documentation.
  • Other: This pull request makes other changes.

Additional information

  • This pull request introduces a breaking change.

Description

Checklist

  • I have performed a self-review of my own code.
  • I have tested my changes, including edge cases.
  • I have added necessary tests for the changes introduced (if applicable).
  • I have updated the documentation to reflect my changes (if applicable).

Additional notes

@KCeh KCeh added the enhancement New feature or request label Sep 10, 2024
@KCeh KCeh requested a review from AsimRibo September 10, 2024 11:10
@KCeh KCeh self-assigned this Sep 10, 2024
email = 'bojan.komljenovic@infinum.com'
id = 'Infinum'
name = 'Infinum Inc.'
email = 'team.android@infinum.com'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is team.android the best option? Any email that goes there is received by the entire team, and that could end up being a bit spammy 🤔 I'd prefer if we had a dedicated email for this.
cc @Aksi0m

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might even remove email
And move to

organization {
                        name = 'Infinum Inc.'
                        url = 'https://infinum.com'
                    }

instead of developer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed email from developer info. Since repos are public there is no barrier in reporting issue on lib.

Also, IMO we should only have organization info. But I found that some tools that collect info for libs sometimes read only developers info and sometimes developer and organization infos are interchangeable.
This is why I added both developer and organization

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I agree 👍

Copy link

Copy link
Contributor

@AsimRibo AsimRibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I do think that alongside organization block, notable contributors should be mentioned in developer block instead of org, per developer block semantics.

Was this agreed as part of our new template?

@KCeh
Copy link
Collaborator Author

KCeh commented Sep 12, 2024

Looks good. But I do think that alongside organization block, notable contributors should be mentioned in developer block instead of org, per developer block semantics.

Was this agreed as part of our new template?

This is still up for debate. Developer block is not mandatory. And developer change over time so I think solution proposed here is best middle ground. Also, I saw that Google puts their name in developer block so we should be fine

@KCeh KCeh merged commit 2ff4786 into master Sep 13, 2024
6 checks passed
@KCeh KCeh deleted the fix/replace-developer-info-with-infinum-info branch September 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants