-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace personal info for publishing with Infinum's info #84
Conversation
sentinel-no-op/publish.gradle
Outdated
email = 'bojan.komljenovic@infinum.com' | ||
id = 'Infinum' | ||
name = 'Infinum Inc.' | ||
email = 'team.android@infinum.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is team.android
the best option? Any email that goes there is received by the entire team, and that could end up being a bit spammy 🤔 I'd prefer if we had a dedicated email for this.
cc @Aksi0m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might even remove email
And move to
organization {
name = 'Infinum Inc.'
url = 'https://infinum.com'
}
instead of developer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed email from developer info. Since repos are public there is no barrier in reporting issue on lib.
Also, IMO we should only have organization info. But I found that some tools that collect info for libs sometimes read only developers info and sometimes developer and organization infos are interchangeable.
This is why I added both developer and organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I agree 👍
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But I do think that alongside organization block, notable contributors should be mentioned in developer block instead of org, per developer block semantics.
Was this agreed as part of our new template?
This is still up for debate. Developer block is not mandatory. And developer change over time so I think solution proposed here is best middle ground. Also, I saw that Google puts their name in developer block so we should be fine |
Summary
Publishing info should reflect that Infinum is developer/maintainer of library. That info is shown when fetching licences with tools like: https://github.com/mikepenz/AboutLibraries
Changes
In all
publish.gradle
files personal info has been replaced with Infinum's infoType
Additional information
Description
Checklist
Additional notes