Fix for running tests #65
Conversation
|
…x-tests-dependencies-04-package-name
|
Tests can be run now and all are passing, some work still needs to be done in |
|
|
||
| <provider | ||
| android:name="androidx.startup.InitializationProvider" | ||
| android:authorities="${applicationId}.androidx-startup" | ||
| android:exported="false" | ||
| tools:node="merge"> | ||
|
|
||
| <meta-data | ||
| android:name="androidx.work.WorkManagerInitializer" | ||
| android:value="androidx.startup" | ||
| tools:node="remove" /> | ||
| </provider> |
There was a problem hiding this comment.
Why is this needed?
We removed need for this in last release
There was a problem hiding this comment.
I can't remember if there were any conflicts, but it is possible it is from that. I will re-check this.
There was a problem hiding this comment.
Okay, I see now. This is from initial commit to this branch by Neven when we were figuring out what is wrong with the tests. I will check if this can be removed.
| WorkManager.initialize( | ||
| context, | ||
| Configuration.Builder().build() | ||
| ) |
There was a problem hiding this comment.
This is only for Tests. WorkManager is missing and SentinelTests couldn't be run.
There was a problem hiding this comment.
By removing meta-data for WorkManager this can also be removed.
| Manifest.permission.POST_NOTIFICATIONS to false, | ||
| Manifest.permission.POST_NOTIFICATIONS to false, |
There was a problem hiding this comment.
Removed, finally 😄
|
Fixed |
| private fun checkDeviceSpecificFields(html: String): String { | ||
| val fields = listOf( | ||
| "screen_width", | ||
| "screen_height", | ||
| "screen_size", | ||
| "screen_density", | ||
| "font_scale" | ||
| ) | ||
|
|
||
| val fieldPatterns = fields.map { field -> | ||
| field to Regex("""<div>$field:\s*[^<]*</div>""") | ||
| } | ||
|
|
||
| var updatedHtml = html | ||
|
|
||
| fieldPatterns.forEach { (field, pattern) -> | ||
| val matchResult = pattern.find(updatedHtml) | ||
| if (matchResult == null) { | ||
| throw AssertionError("Field $field is missing in the device object") | ||
| } else { | ||
| updatedHtml = updatedHtml.replace(matchResult.value, """<div>$field: </div>""") | ||
| } | ||
| } | ||
|
|
||
| return updatedHtml | ||
| } | ||
|
|
There was a problem hiding this comment.
When it comes to StringBuilder tests I didn't find an elegant way to mock these fields like it is the case with ReflectionHelpers. So I went with this approach because I think it is only important to assert that field is there.
When I get more familiar with Roboelectric, I will return to this, unless you have suggestions.
There was a problem hiding this comment.
Kudos for taking the initiative and finally patching up tests 🚀
I also don't have too much exp with 🤖 Robolectric and I see we quite often have patterns like checkDeviceSpecificFields in tests. I assume we could probably improve that. But first and foremost everything is running as expected!
P.S.
Maybe you could share you gained knowledge on internal edu or team events 🤔
P.S. Part II
Take a look at Notification permission comment
| Manifest.permission.POST_NOTIFICATIONS to false, | ||
| Manifest.permission.POST_NOTIFICATIONS to false, |
| @@ -10,7 +10,7 @@ | |||
| <application> | |||
|
|
|||
| <activity | |||
| android:name=".ui.main.SentinelActivity" | |||
| android:name="com.infinum.sentinel.ui.main.SentinelActivity" | |||
|
📷 Screenshots
📄 Context
Tests can finally be run. Some of them are failing but that is a problem for another day.
📝 Changes
📎 Related PR
🚫 Breaking
🛠️ How to test
⏱️ Next steps