-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies 04-2024 #63
Changes from 29 commits
e22b5de
09a6178
03fc3fd
141900f
71af394
7ad4ec6
558d44f
8464c86
5677744
d1867ca
c208281
d1caa9d
fdb0fa2
333d160
ac0ad7b
673a24a
82d2f00
885e58c
2caeb75
6c2c390
e5bd2c8
c9befa3
a56cef6
eabfceb
31b7574
f1997c9
0e8dbec
0de374f
228d3a0
58526d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.2-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
package="com.infinum.sentinel" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Package name inside of AndroidManifest is not supported anymore and we were getting errors/warnings, don't remember. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can set the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you don't need to set namespace for tests (manifest for tests), gradle will just append .test by default https://developer.android.com/build/configure-app-module#change-namespace-for-testing |
||
android:versionCode="100000" | ||
android:versionName="1.0.0"> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the project already has 2 versions defined, would be good to go in a different direction than this and use a single version everywhere. On some libraries like PrinceOfVersions we have a gradle task to update readme with the current version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correctly updated on
master
, but it seems we forgot to merge this change ondevelop
. But you are right, this would be an improvement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add idea for Gradle task to the list