You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue when updating AGP version from 8.0 to 8.3 where a project that uses sentinel would need to have desugaring enabled. Removing this also removes the need to add desugaring in other projects.
Correct, upgrading AGP to 8.3.0 will result in clients of library needing to use desugaring (https://issuetracker.google.com/issues/329346764)
So I agree it is probably better to remove it. But then we also need to change the code that is affected by this change.
I have removed desugaring from Sentinel.
Sentinel's version of ChronoUnit is introduced to avoid the need for DB refactoring. Other than that in place where Java 8 Time API is needed checks and Require annotations are added. Therefore, certificate tools is no longer supported on devices API < 26
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Changes
There was an issue when updating AGP version from 8.0 to 8.3 where a project that uses sentinel would need to have desugaring enabled. Removing this also removes the need to add desugaring in other projects.