Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Trigger active value not correct in some cases #48

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Fix: Trigger active value not correct in some cases #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8109d2a
Add remember active state of sensor trigger
KCeh Feb 13, 2024
247642a
Update cache when saving Trigger DAO
KCeh Feb 13, 2024
8a5f749
Fix lint
KCeh Feb 13, 2024
23ebca4
Merge branch 'develop' into fix/trigger-init-not-working-properly-on-…
KCeh Mar 1, 2024
4464222
Merge branch 'develop' into fix/trigger-init-not-working-properly-on-…
KCeh Mar 1, 2024
3d28a7e
Merge branch 'develop' into fix/trigger-init-not-working-properly-on-…
KCeh Mar 4, 2024
4dbbe12
Remove sensor trigger
KCeh Mar 6, 2024
c0eee7b
Merge branch 'develop' into fix/trigger-init-not-working-properly-on-…
KCeh Mar 6, 2024
d4741a6
Merge branch 'develop' into fix/trigger-init-not-working-properly-on-…
KCeh Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .../src/main/kotlin/com/infinum/sentinel/data/models/memory/triggers/shared/SensorTrigger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ internal abstract class SensorTrigger(
sensorManager = (context.getSystemService(Context.SENSOR_SERVICE) as? SensorManager)
sensorManager?.let {
registerSensor(it)
this.active = true
} ?: run {
this.active = false
}
Expand All @@ -34,7 +33,6 @@ internal abstract class SensorTrigger(
queue?.clear()
unregisterSensor()
sensorManager = null
this.active = false
}

override fun onSensorChanged(event: SensorEvent) {
Expand Down
1 change: 1 addition & 0 deletions sentinel/src/main/kotlin/com/infinum/sentinel/domain/triggers/TriggersRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ internal class TriggersRepository(
override suspend fun save(input: TriggerParameters) =
input.entity?.let {
dao.save(it)
updateCache(it)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is crucial and probably the fix for all the problems. Good work 👏

} ?: error("Cannot save null entity")

override fun load(input: TriggerParameters): Flow<List<TriggerEntity>> =
Expand Down
Loading