Merge pull request #73 from infinum/fix/Exported-component-access-sho…

…uld-be-restricted-with-appropriate-permissions Fix: exported component access should be restricted with appropriate permissions
infinum · Jul 17, 2024 · 3527381 · 3527381
2 parents 1a5116c + 7f79a81
commit 3527381
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/sentinel/src/main/AndroidManifest.xml b/sentinel/src/main/AndroidManifest.xml
@@ -3,15 +3,20 @@
 
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
 
+    <permission
+        android:name="com.infinum.sentinel.permission.ACCESS_SENTINEL"
+        android:protectionLevel="signature" />
+
     <application>
 
         <activity
             android:name=".ui.main.SentinelActivity"
             android:exported="true"
             android:label="@string/sentinel_name"
             android:taskAffinity="com.infinum.sentinel"
-            android:theme="@style/Sentinel.Theme">
-            <meta-data
+            android:theme="@style/Sentinel.Theme"
+            android:permission="com.infinum.sentinel.permission.ACCESS_SENTINEL">
+        <meta-data
                 android:name="@string/sentinel_infinum_monitored"
                 android:value="false" />
         </activity>

diff --git a/tool-timber/src/main/kotlin/com/infinum/sentinel/SentinelFileTree.kt b/tool-timber/src/main/kotlin/com/infinum/sentinel/SentinelFileTree.kt
@@ -4,7 +4,7 @@ import android.content.Context
 import com.infinum.sentinel.ui.logger.models.BaseEntry
 import com.infinum.sentinel.ui.logger.models.FlowBuffer
 import com.infinum.sentinel.ui.logger.models.Level
-import com.infinum.sentinel.ui.shared.Constants.LOG_DATE_TIME_FORMAT
+import com.infinum.sentinel.ui.shared.TimberToolConstants.LOG_DATE_TIME_FORMAT
 import com.infinum.sentinel.ui.shared.LogFileResolver
 import java.io.File
 import java.text.SimpleDateFormat

diff --git a/tool-timber/src/main/kotlin/com/infinum/sentinel/ui/logger/LoggerAdapter.kt b/tool-timber/src/main/kotlin/com/infinum/sentinel/ui/logger/LoggerAdapter.kt
@@ -5,7 +5,7 @@ import android.view.ViewGroup
 import androidx.recyclerview.widget.ListAdapter
 import com.infinum.sentinel.SentinelFileTree
 import com.infinum.sentinel.databinding.SentinelItemLogBinding
-import com.infinum.sentinel.ui.shared.Constants.LOG_DATE_TIME_FORMAT
+import com.infinum.sentinel.ui.shared.TimberToolConstants.LOG_DATE_TIME_FORMAT
 import java.text.SimpleDateFormat
 import java.util.Locale
 

diff --git a/tool-timber/src/main/kotlin/com/infinum/sentinel/ui/logs/LogsAdapter.kt b/tool-timber/src/main/kotlin/com/infinum/sentinel/ui/logs/LogsAdapter.kt
@@ -4,7 +4,7 @@ import android.view.LayoutInflater
 import android.view.ViewGroup
 import androidx.recyclerview.widget.ListAdapter
 import com.infinum.sentinel.databinding.SentinelItemLogFileBinding
-import com.infinum.sentinel.ui.shared.Constants.LOG_DATE_TIME_FORMAT
+import com.infinum.sentinel.ui.shared.TimberToolConstants.LOG_DATE_TIME_FORMAT
 import java.io.File
 import java.text.SimpleDateFormat
 import java.util.Locale

diff --git a/...m/infinum/sentinel/ui/shared/Constants.kt → ...sentinel/ui/shared/TimberToolConstants.kt b/...m/infinum/sentinel/ui/shared/Constants.kt → ...sentinel/ui/shared/TimberToolConstants.kt
@@ -1,5 +1,5 @@
 package com.infinum.sentinel.ui.shared
 
-internal object Constants {
+internal object TimberToolConstants {
     const val LOG_DATE_TIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSSZ"
 }