Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try out NumpyArrayContext #427

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Try out NumpyArrayContext #427

wants to merge 1 commit into from

Conversation

alexfikl
Copy link
Collaborator

This adds a subclass of NumpyArrayContext and uses it in test_array.py and test_meshmode.py (these also used the pytato array context).

I'm not sure if this is supposed to just work™, but I was curious what fails 😁

@alexfikl alexfikl mentioned this pull request Aug 12, 2024
Merged
1 task
@alexfikl
Copy link
Collaborator Author

From a quick skim:

  • There seem to be some cool segmentation faults in there.
  • The loopy kernels are not all super friendly with the C target (most seem to be missing a barrier implementation?)

@inducer
Copy link
Owner

inducer commented Aug 12, 2024

Thanks for doing this. All this is definitely intended to "just work", at least eventually.

@alexfikl alexfikl closed this Sep 5, 2024
@inducer
Copy link
Owner

inducer commented Sep 5, 2024

What made you decide to close this? I figure we'll want something like this in the medium term?

@alexfikl
Copy link
Collaborator Author

alexfikl commented Sep 5, 2024

What made you decide to close this? I figure we'll want something like this in the medium term?

Just didn't think it was needed. I'm happy to reopen!

@alexfikl alexfikl reopened this Sep 5, 2024
alexfikl
alexfikl commented Sep 5, 2024
View reviewed changes
meshmode/array_context.py
"to create this kernel?")

import loopy as lp
return lp.add_inames_for_unused_hw_axes(t_unit)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an attempt to silence some loopy errors. Not sure if it's a good idea..

@inducer inducer mentioned this pull request Nov 28, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfikl @inducer