Split dataclass_array_container #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
force-pushed
the
dataclass-annotations
branch
2 times, most recently
from
b45f383 to
201f973
Compare
11 tasks
alexfikl
force-pushed
the
dataclass-annotations
branch
from
201f973 to
c421cfe
Compare
inducer
reviewed
Jun 24, 2022
alexfikl
force-pushed
the
dataclass-annotations
branch
2 times, most recently
from
1758e4b to
4ba3383
Compare
alexfikl
force-pushed
the
dataclass-annotations
branch
from
4ba3383 to
5eb10d8
Compare
alexfikl
changed the title
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the code generation bits out of
dataclass_array_containerso that other packages can more easily implement similar behavior (notablyboxtreeat the moment).