Update project #16
Merged
Update project #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
reviewed
Jan 5, 2025
keynmol
reviewed
Jan 5, 2025
Comment on lines
+6
to
+7
| release: | ||
| types: [ 'published' ] |
There was a problem hiding this comment.
Why change this? I don't think I've ever had an issue with the tags: setting in the dozens of projects I released on github
There was a problem hiding this comment.
It follows the intended semantics: You want to run the action when you publish a release on GitHub.
In all likelihood, you don't want to run the action when you push a tag various-fixes or whatever, right?
keynmol
reviewed
Jan 5, 2025
Comment on lines
+23
to
+26
| - name: Set Swap Space | ||
| uses: pierotofy/set-swap-space@master | ||
| with: | ||
| swap-size-gb: 10 |
There was a problem hiding this comment.
Is this some sort of universal recommendation? What does this help with?
There was a problem hiding this comment.
The CI fails otherwise. It seemed like insufficient memory, so I added it. And now it's green.
keynmol
reviewed
Jan 5, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the CI work and other niceties.