Allow use of JDBC session on separate DB

[DonaldChung-HK]

Description

This change allows the use of JDBC for saving HTTPSession data in a separate database. This is to support our use of Galera DB as our HA backend option. The change will allow use to reduce administrative burden and attack surface via not needing to run a cross data centre Redis. setup.

The code should only activate if jdbc spring session is used.

Fixes #809

[DonaldChung-HK]

I have added the missing new line at iam-login-service/src/main/resources/application-jdbc-session.yml so the licence check should pass now

[sonarqubecloud]

Quality Gate failed

Failed conditions
54.5% Coverage on New Code (required ≥ 85%)

See analysis details on SonarCloud

[rmiccoli]

I think we don't need @Primary and @Qualifier annotations since Spring will manage the different data sources based on the condition set. So,

• when spring.session.store-type=jdbc is enabled, both primaryDataSource and sessionDataSource are created, and Spring Session uses session database for storage persistence;
• when spring.session.store-type=jdbc is not set, only primaryDataSource is created and used for general database operations including session management.

[rmiccoli]

Also this annotation should be unnecessary here

[DonaldChung-HK]

Hi, I think it does need to @Qualifier since otherwise there will be 2x non unique beans for datasource, one is the autoconfigured one and another one is this customer one?

[DonaldChung-HK]

Hi,
The test I have above is failing due to MySQL too many connections at the OidcExternalAuthenticationTests. It is strange cause in local development environment, all tests pass but it seems that in local environment, it uses h2 instead of MySQL. Could you please investigate?

Edit: I have made changes so that the Hikari object is a singleton and don't create too many connection below

[sonarqubecloud]

Quality Gate failed

Failed conditions
54.5% Coverage on New Code (required ≥ 85%)

See analysis details on SonarQube Cloud