Reset the client secret when the authentication is set to none #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or else, generate a new Random secret.
giacomini
reviewed
Dec 7, 2023
| if (newClient.getTokenEndpointAuthMethod().equals(AuthMethod.NONE)) { | ||
| newClient.setTokenEndpointAuthMethod(AuthMethod.NONE); | ||
| newClient.setClientSecret(null); | ||
| } else if (!newClient.getTokenEndpointAuthMethod().equals(AuthMethod.NONE) |
There was a problem hiding this comment.
Isnt' the condition !newClient.getTokenEndpointAuthMethod().equals(AuthMethod.NONE) useless, since we are in the else branch of that condition?
giacomini
reviewed
Dec 7, 2023
| if (newClient.getTokenEndpointAuthMethod().equals(AuthMethod.NONE)) { | ||
| newClient.setTokenEndpointAuthMethod(AuthMethod.NONE); | ||
| newClient.setClientSecret(null); | ||
| } else if (!newClient.getTokenEndpointAuthMethod().equals(AuthMethod.NONE) |
|
SonarCloud Quality Gate failed.
|
|
Replaced by #677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a clients is public (i.e. the "Token endpoint authentication method" box is checked to
No authentication) the secret was still present in the db and a token request was resulting in a "Bad credentials" response.Now the secret is set to
nullwhen the client is public and no more authentication is required at the token endpoint.