Add support for admin to customize login layout #668
Conversation
Sae126V
requested review from
enricovianello,
federicaagostini,
rmiccoli and
a team
| Sign in with your ${iamOrganisationName} credentials | ||
| </c:when> | ||
| <c:otherwise> | ||
| Or sign in with your ${iamOrganisationName} credentials |
There was a problem hiding this comment.
In our scenario, Assuming that user want external authn block to be displayed first, Now for our local credentials section, we have to change the text to or sign in. Does that make sense, ?
| test="${ | ||
| ( | ||
| loginPageConfiguration.localAuthenticationVisible | ||
| or param.sll != null |
There was a problem hiding this comment.
Can or be || (for uniformity)?
There was a problem hiding this comment.
Sure..Updated the code to be consistent,
| <jsp:include page="login-form.jsp" /> | ||
| <c:if | ||
| test="${ | ||
| !loginPageConfiguration.defaultLoginPageLayout |
There was a problem hiding this comment.
Isn't this equivalent to !loginPageConfiguration.defaultLoginPageLayout || !loginPageConfiguration.localAuthenticationVisible && param.ssl == null?
There was a problem hiding this comment.
Simplified the logic. Done
| <c:choose> | ||
| <c:when | ||
| test="${ | ||
| ( |
There was a problem hiding this comment.
Isn't this equivalent to loginPageConfiguration.defaultLoginPageLayout && (loginPageConfiguration.localAuthenticationVisible || param.sll != null)
There was a problem hiding this comment.
Simplified the logic. Done
|
Kudos, SonarCloud Quality Gate passed! |
Resolves #298.
TODO:
Update https://indigo-iam.github.io/ with relevant information.