Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ApifonIM service supports only Viber #472

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Make ApifonIM service supports only Viber #472

wants to merge 2 commits into from

Conversation

eskour
Copy link
Contributor

@eskour eskour commented Nov 29, 2024

  • Make ApifonIM service supports only Viber so the ISmsServiceFactory can resolve both Apifon and ApifonIM based on SMS or Viber delivery channel.
  • Respect ViberFallbackEnabled option in ApifonIM

cleftheris
cleftheris requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@cleftheris cleftheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the point its your usecase only so propably will be rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleftheris cleftheris cleftheris requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eskour @cleftheris