Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decross tweaks #40

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Decross tweaks #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e7bb28
LMSA-9500 - edit text on decrosslist page
gjthomas Nov 26, 2024
f10daff
LMSA-9499 - force sisSectionId passed to Canvas to be uppercase
gjthomas Nov 26, 2024
ea10662
LMSA-9499 - efficiency change for uppercase
gjthomas Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ public FindParentResult processSisLookup(String sisSectionId) {
return findParentResult;
}

Section section = sectionService.getSection(String.format("sis_section_id:%s", sisSectionId));
// this style of Canvas search is case-sensitive, so let's force the upper case that will be accurate for SIS
Section section = sectionService.getSection(String.format("sis_section_id:%s", sisSectionId.toUpperCase()));

if (section == null) {
findParentResult.setShowCourseInfo(false);
Expand Down
6 changes: 3 additions & 3 deletions src/main/resources/templates/findParentCourse.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ <h2 id="results-message" tabindex="-1" th:text="|Parent course found: ${findPare
</div>
<div class="rvt-m-top-sm">
<span>
Select sections to remove, then activate De-cross-list selected sections to de-cross-list
them from the course. Unavailable sections are due to either not having a SIS ID or it is
the course's original section.
Select sections to remove, then activate the 'De-cross-list selected sections' button to
remove those sections from the course. Unavailable sections are those that do not have an
SIS ID, or it is the course's original section.
</span>
</div>
</div>
Expand Down
Loading