Lmsa 7719 library update #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsobiera
commented
Sep 7, 2023
| @@ -74,13 +74,13 @@ <h1 class="rvt-alert__title" id="error-alert-title">Cross-listing Error</h1> | |||
| </p> | |||
There was a problem hiding this comment.
Forgot to convert stuff above this
gjthomas
reviewed
Sep 7, 2023
| <button id="modal-submit" class="rvt-button" disabled="disabled" aria-disabled="true" | ||
| name="action" th:value="${T(edu.iu.uits.lms.crosslist.CrosslistConstants).ACTION_IMPERSONATE}">Submit</button> | ||
| </div> | ||
| </form> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <!--</div>--> |
mrw-iu
reviewed
Sep 7, 2023
| @@ -62,14 +61,13 @@ | |||
| </form> | |||
| </div> | |||
|
|
|||
| <div layout:fragment="content" class="rvt-container" role="main">Page content goes here</div> | |||
| <div layout:fragment="content" class="rvt-container-xl" role="main">Page content goes here</div> | |||
|
|
|||
There was a problem hiding this comment.
Add aria-label="Cross-listing Assistant" to the div with role=main
Lmsa 7719 a11y
…t_course Lmsa 7975 lookup parent course
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.