Skip to content

Commit

Permalink
Merge pull request #41 from indiana-university/LMSA-9502
Browse files Browse the repository at this point in the history
LMSA-9502 - add a different display for non-SIS courses
  • Loading branch information
gjthomas authored Dec 3, 2024
2 parents 81580f0 + 5ccb0d9 commit 55d52ee
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ public String lookupSearchBySisId(@ModelAttribute FindParentModel findParentMode
model.addAttribute("availableToDecrosslistSectionsList", availableToDecrosslistSectionsList);

model.addAttribute("findParentResult", findParentResult);

// add canvasCourseId to be used in audit log purposes later
model.addAttribute("canvasCourseId", findParentResult.getCanvasCourseId());

Expand Down Expand Up @@ -203,6 +204,7 @@ public String decrossListSections(@RequestParam("section-checkboxes") List<Strin

if (findParentResult != null) {
model.addAttribute("findParentResult", findParentResult);

// add canvasCourseId to be used in audit log purposes later
model.addAttribute("canvasCourseId", findParentResult.getCanvasCourseId());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,8 @@ public class FindParentResult {
private String statusIconName;
private String canvasCourseId;
private List<Section> sectionList;

public String displaySisCourseId() {
return sisCourseId == null ? "non-SIS course" : sisCourseId;
}
}
2 changes: 1 addition & 1 deletion src/main/resources/templates/findParentCourse.html
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ <h1 id="tool-title" class="rvt-p-top-sm rvt-ts-36">De-cross-listing sections</h1
<form th:object="${findParentModel}" id="decrosslist-form" th:action="@{|/app/decrosslist-sections|}" method="post">
<div class="rvt-flex rvt-items-center">
<rvt-icon th:name="${findParentResult.statusIconName}" class="rvt-border-radius-circle rvt-p-all-xs" th:classappend="${findParentResult.statusIconCssClasses}"></rvt-icon>
<h2 id="results-message" tabindex="-1" th:text="|Parent course found: ${findParentResult.sisCourseId}|" class="rvt-ts-18 rvt-text-bold rvt-p-left-xs">Parent course found</h2>
<h2 id="results-message" tabindex="-1" th:text="|Parent course found: ${findParentResult.displaySisCourseId}|" class="rvt-ts-18 rvt-text-bold rvt-p-left-xs">Parent course found</h2>
</div>
<div>
<div class="rvt-p-top-sm">
Expand Down

0 comments on commit 55d52ee

Please sign in to comment.