-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sccomp insekp #40
Open
hansvancalster
wants to merge
7
commits into
main
Choose a base branch
from
sccomp-insekp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sccomp insekp #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have improved the figure in previous comment by showing "odds-ratios" in the x-axis instead of "log-odds-ratios". Added some text to explain how the contrasts are calculated and how odds-ratios can be interpreted. |
nick-dil
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nick-dil approves this PR,with some remarks:
- I will need to implement the changes @hansvancalster made in this PR to the rmd we used for sccomp analysis on the HPC (https://github.com/slambrechts/INBO_eDNA_metabarcoding_BODEM/issues/218).
- Maybe its a bit weird to work in separate repositories for the same analysis - > Should we look to centralize this code in 1 repo only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a test for sccomp package on a subset of insekp data. Most relevant to look at is how to get significant taxa based on c_FDR and plot only those taxa.