Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event subclass fix ios #133

Conversation

blairmacintyre
Copy link
Contributor

This is the code that fixes issue #130

@jsantell
Copy link
Contributor

jsantell commented Jan 2, 2020

I misunderstood in #130, I'm following you now -- found more info (or at least the same problem) here; happy that this works! Could you squash this down to one commit? I'll merge it in then. Thank you!

@blairmacintyre
Copy link
Contributor Author

pretend I'm a git noob (not a stretch); how do I squash to a single commit? :)

@jsantell
Copy link
Contributor

jsantell commented Jan 2, 2020

pretend I'm a git noob (not a stretch); how do I squash to a single commit? :)

I use a shortcut git rebase -i HEAD~$1 where $1 is how many previous commits you'd like to squash -- then squash all commits except the top one (could be any commit really), and modify the final commit message. As is all things git, not sure if this is the correct way, but just the magical incantation I've internalized 😄

typo: this.immersive should be this[PRIVATE].immersive

fix for iOS bug in subclassing system classes
typo: this.immersive should be this[PRIVATE].immersive

fix for iOS bug in subclassing system classes
@blairmacintyre
Copy link
Contributor Author

I can't get it to work ... I seem to keep adding empty commits ... I'm just going to close this, it's a mess.

@blairmacintyre
Copy link
Contributor Author

@jsantell I gave up on figuring out my git incompetance and just submitted a new PR #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants