Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade dependencies #386

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Upgrade dependencies #386

wants to merge 6 commits into from

Conversation

icco
Copy link

@icco icco commented Sep 19, 2024

Description

This does a few things:

  • BREAKING CHANGE: requires node >= 20
  • upgrades rollup to new package schema
  • removes uglifyjs as it's rollup plugin is no longer supported
  • Upgrades packages with known security vulnerabilities
  • Migrates to .mjs as required in newer node versions

Checklist

  • Read the contributing guidelines.
  • Each commit follows the Conventional Commit spec format.
  • Update the readme (if applicable).
  • Update or add any necessary API documentation (if applicable)
  • All existing unit tests are still passing (if applicable).
  • Add some steps so we can test your bug fix or feature (if applicable).
  • Add new passing unit tests to cover the code introduced by your PR (if applicable).
  • Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
  • If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

BREAKING CHANGE: requires node >= 20
@icco icco force-pushed the upgrade branch 2 times, most recently from 5e5cfa3 to cc37b84 Compare September 19, 2024 13:34
@icco icco marked this pull request as ready for review September 19, 2024 13:50
@icco icco requested a review from a team as a code owner September 19, 2024 13:50
@icco icco changed the title fix: Upgrade dependencies and adjust requires fix: Upgrade dependencies Sep 19, 2024
@marco-salcedo
Copy link

@icco thank you so much for contributing! Since this PR is tackling several things we want to make sure we fix your issue without impacting other environments that are using the library.

Could you please provide more insight into what the issue(s) you are running into is/are?
e.g. why do you require dependency updates, need a specific node version, need the files to be imported as .mjs, etc

Also, could you please rewrite your commits to make sure we don't check in the distribution files in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants