Merge pull request #118 from imbrn/fix/integer-rule

Fix bug with `integer` rule
imbrn · Aug 29, 2018 · 7fac227 · 7fac227
2 parents 286b97b + f4bb141
commit 7fac227
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+- Bug with polyfill for `integer` rule
+
 ## [1.2.1] - 2018-08-17
 
 ### Changed

diff --git a/src/v8n.js b/src/v8n.js
@@ -147,7 +147,7 @@ const availableRules = {
     return testIncludes(expected);
   },
 
-  integer: () => value => Number.isInteger(value) || testIntegerPolyfill(value),
+  integer: () => testInteger(),
 
   schema: schema => testSchema(schema),
 
@@ -221,7 +221,12 @@ function testIncludes(expected) {
   return value => value.indexOf(expected) !== -1;
 }
 
-function testIntegerPolyfill(value) {
+function testInteger() {
+  const isInteger = Number.isInteger || isIntegerPolyfill;
+  return value => isInteger(value);
+}
+
+function isIntegerPolyfill(value) {
   return (
     typeof value === "number" && isFinite(value) && Math.floor(value) === value
   );