Skip to content

Commit

Permalink
Tweak github actions
Browse files Browse the repository at this point in the history
  • Loading branch information
lilith committed Jun 28, 2023
1 parent 1872674 commit a64eac8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/dotnet-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,15 @@ jobs:
path: 'host/publish/'

# Upload the publish folder for src/Imageflow.Server.Host to the release artifacts
- name: Upload Server.Host to artifacts
- name: Upload Imageflow.Server.Host to artifacts
uses: actions/upload-artifact@v3
if: success()
with:
name: ${{env.HOST_ZIP_FILE}}}}
name: ${{env.HOST_ZIP_FILE}}
path: host/${{env.HOST_ZIP_FILE}}

# If this is a release, upload it to the github release page using the git
- name: Upload ${{env.HOST_ZIP_FILE}} to release
- name: Upload Imageflow.Server.Host to release
uses: Shopify/[email protected]
if: steps.version.outputs.is_valid == 'true' && github.event_name == 'release'
with:
Expand Down
9 changes: 8 additions & 1 deletion CONFIGURATION.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
# TOML Configuration for Imageflow.Server.Host

Hooray! You no longer need a build step to deploy Imageflow Server. We're publishing a precompiled project that uses Imageflow.Server.Configuration, and auto-restarts when you edit imageflow.toml (we hope).
Hooray! You no longer need a build step to deploy Imageflow Server. We're publishing a precompiled project that uses Imageflow.Server.Configuration.

That said, having a repository with your configuration and some automated deploy/CI is still a GREAT idea, so you may copy/paste Imageflow.Server.Host into your own project, or use it as a reference for your own deployment.

**NOTE: This is a work-in-progress, bugs may exist, and error messages when you mess the config file up may be confusing. Please report any issues.**

#### Known issues

* Doesn't auto-restart when you edit imageflow.toml
* env.HOME doesn't work on windows. Use env.TEMP instead for a good default image cache folder
* app.wwwroot shouldn't be used, wwwroot isn't reliably defined and is just a bad idea with ASP.NET 7. Use '${app.approot}/public' instead.
* No support for configuring S3 or Azure or remote HTTP sources yet. It's tricky to get just right and in an extensible way; I've supported <resizer> in Web.config for 15 years, so I want to avoid breakage.

## General ASP.NET deployment help.

Imageflow.Server.Host can be copy/pasted into your IIS site, and configured with imageflow.toml Don't forget to install the ASP.NET Hosting Bundle if you're deploying to windows.
Expand Down

0 comments on commit a64eac8

Please sign in to comment.