Update .travis.yml to build jpeg-archive binary #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Why are you not just calling https://github.com/danielgtaylor/jpeg-archive/blob/master/Makefile ? |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "jpeg-recompress-bin", | |||
| "version": "5.1.1", | |||
| "version": "5.1.2", | |||
There was a problem hiding this comment.
Don't bump version in a PR. Applies in general.
|
I don't think you should remove the fallback to compile from source. It can be useful for some Linux systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this comment #18 (comment)
I just updated
.travis.ymlfile to buildjpeg-archivebinary for windows, linux, osx.Once successfully built, it will be deployed to GitHub Releases page automatically.
Then, this package will download the latest binary from GitHub Releases page
Please create your
personal access tokenwithwrite permissionand add this token in the travis setting page namedgithub_tokenPlease create the new tag after merging!
If the commit is not tagged, deploying to GitHub Releases page will be ignored