-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a null filter to re-enable frame count #107
Conversation
This aims at addressing imageio#99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also confirmed that this patch works well for us. Thanks!
Bug: imageio/imageio-ffmpeg#99 Pull-Request: imageio/imageio-ffmpeg#107 Signed-off-by: Michał Górny <[email protected]>
CI fails on one specific test: imageio-ffmpeg/tests/test_io.py Lines 40 to 43 in 9ab981a
The result is Nonetheless, I think its safe to just update theupper bound to |
I can confirm this fix works for M1/M2 macbooks as well. |
@tvercaut could you update the test I referenced in my earlier comment? That should make the tests pass, so we can merge this 🚀 |
@almarklein can't you just update the tests? Looks like OP isn't that active. |
I just pushed the requested test relaxation change for the PR. |
@almarklein can you publish a new version pypi version? |
done! |
This aims at addressing #99