Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cpp: do not pass #error into output stream, warn about it and exit non-0" #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

citrus-it
Copy link
Member

This reverts commit ee5767d.

This commit seems wrong.

With it, if you compile cpp without EXIT_ON_ERROR defined, cpp just doesn't understand #error at all and outputs things like this during a gate build:

.../usr/include/sys/asm_linkage.h: 102: undefined control

With EXIT_ON_ERROR set, a gate build fails with:

  sys/asm_linkage.h: 102: #error      "inconsistent shift constants"

I think it's wrong to have a switch with toggles between "#error not understood" and "#error acted upon" and we should revert to "#error passed through to output stream" (as per OmniOS and SmartOS today) and "#error acted upon" - and then we can work on making the latter work with a gate build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant