-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub markdown alert extension for warning #43
Conversation
I assume the intent of the block was: https://github.com/orgs/community/discussions/16925 Also tried to clarify the text.
If you think people generally go for the readme rather than docs, maybe we should change it....I guess our docs are basically just the README anyway... |
We’ll probably remove the warning before publishing anyway right? |
I think we should put it on PyPI in an experimental state so people can use it instead of installing from here, no? |
OK sure, we can simply start by only publishing pre-release versions. But then we want to use syntax that PyPI can actually render properly. Btw: reStructuredText has wonderful built-in admonitions for exactly that purpose wink |
@flying-sheep will investigate PyPI rendering as well, but it's the same issue where it can't render the Github syntax (so we think, but need to check). |
OK, so PyPI uses As far as that parser is concerned, the admonitions don’t exist. They are instead part of GitHub’s post-processing like converting So to see how things look on PyPI, do this: uv run --isolated --with=readme-renderer[md] python -m readme_renderer README.md GitHub doesn’t seem to give a fuck about properly rendering rST, so switching to rST is not a panacea: github/markup#1682 This leaves us between a rock and a hard place: either it looks “bad” on GitHub or it looks bad on PyPI. The docs rendering of this PR’s version might be possible, see executablebooks/MyST-Parser#845 To be honest, I like the current compromise more than |
Then let's close for now, I think. But we've learned something! |
I assume the intent of the warning code block was: https://github.com/orgs/community/discussions/16925
Also tried to clarify the text.