Fix flaky ServerStatusManagerIntegrationTest #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This PR tries to solve the flakiness of `ServerStatusManagerIntegrationTest` in a different way. See line#948 This workaround minimizes port collisions by ensuring that all ports are available when a Central Dogma cluster starts. Modifications: - Check if all ports are open when restarting `CentralDogmaReplicationExtension`. Result: Less flakiness
ikhoon
force-pushed
the
fix-flaky-test-v2
branch
from
83d2f39 to
7d9a211
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
============================================
+ Coverage 66.77% 70.50% +3.72%
- Complexity 3514 3680 +166
============================================
Files 370 376 +6
Lines 14476 14796 +320
Branches 1553 1591 +38
============================================
+ Hits 9667 10432 +765
+ Misses 3932 3433 -499
- Partials 877 931 +54 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.