fix Cancel Create Key Map in MCReader #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Read Tag, clicking on Cancel after Start Mapping and read tag can take several seconds before the App is available to start another mapping. This is due to the high number of keys being tried in
MCReader
.This fix propagates the Cancel request to
MCReader
and exit the for loops inbuildNextKeyMapPart()
.Step to reproduce:
Old behavior:
Cancel can take several seconds to complete
New behavior:
Cancel resolves immediately