Corrected the addon file locations for TypeScript projects #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
changed the title
ijlee2
force-pushed
the
bugfix-publicEntrypoints
branch
from
e483f9d to
b4b1c7d
Compare
ijlee2
force-pushed
the
bugfix-publicEntrypoints
branch
from
b4b1c7d to
f98e42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
For
addon.publicEntrypoints(), I had listedindex.jsandtemplate-registry.jsbased on@embroider/addon-blueprint.I realized that we need to instead list the files as is, i.e. with
.tsin TypeScript projects. The addons worked without an issue by accident, because@embroider/addon-devhas been including**/*.ts.Note
If a consumer had
addon-test-support/index.{js,ts}in their v1 addon, they will need to addtest-support.js(ortest-support.ts) toaddon.publicEntrypoints()in the Rollup configuration.