-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All we need to do is listen. #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glatterf42
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks :)
Just one question about wording in-line :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I've replaced the current audit information setup (calling
set_creation_info
when creating an object) with a listener system in anticipation for the versioning change.I've added the class
SqlaEventHandler
to be instantiated in each database backend. This handler listens to three events explained in the docstrings.If the event targets inherit from the new mixins (by fridolin, moved and refactored by me here), special data will be injected into the queries that serves to set/update the relevant columns without an extra query dispatch. This is documented in the mixin docstrings.
The following test was added:
As far as I can see this is the only place where the current rules apply.
Run
is the only model that can be updated directly (so i addedHasUpdateInfo
to its parents).Note that this does not include the functionality to automatically update the
UpdateInfo
when related objects are changed.For example when using
Run.iamc.add
orRun.iamc.remove
.This is on purpose as I think it will make these PRs easier to review. My plan is to implement some sort of "ownership" system that can be used for update information, orphan deletion and permission checking all at the same time. A short summary could be that we want to allow rows to own other rows along foreign keys. For example a Run owns multiple TimeSeries which in turn own multiple DataPoints. More to follow in a seperate PR.
More:
async_client
from api backend as it was emitting deprc. errors and is no longer used.