Add extra check if both values are NA in bulk_upsert #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -391,7 +391,10 @@ def bulk_upsert_chunk(self, df: pd.DataFrame) -> None: | |||
| for col in self.model_class.updateable_columns: | |||
| updated_col = col + self.merge_suffix | |||
| if updated_col in df.columns: | |||
| cond.append(df[col] != df[updated_col]) | |||
| df[updated_col] = df[updated_col].astype(df[col].dtype) | |||
There was a problem hiding this comment.
Maybe add a line explaining why this is necessary? And a test (in a GitHub Action that explicitly installs pyarrow) to guard against regression?
4 tasks
|
Do we intend to release 0.7.1 immediately after this fix so that IAMconsortium/pyam#820 can move forward? |
glatterf42
approved these changes
Feb 29, 2024
|
Alright I added a test matrix entry for pyarrow and python 3.12. Also added some comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50 's pyarrrow compatibility problem.