Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Builds on Publish #47

Merged
merged 22 commits into from
Feb 13, 2024
Merged

Docker Builds on Publish #47

merged 22 commits into from
Feb 13, 2024

Conversation

meksor
Copy link
Contributor

@meksor meksor commented Feb 9, 2024

Adds a github action which is supposed to build containers on tags-pushed or publish.

@meksor
Copy link
Contributor Author

meksor commented Feb 9, 2024

OK, phew that took a while to get right.
To ensure compatibility with the broken docker version on some of the IIASA servers, we need to pin the buildkit moby image to version v0.10.5 and disable pip progress bars.
Anyway, full releases are tagged with the version string and "latest" while pushed git tags are taggs with the version string and "dev" (similar to the pypi and test-pypi uploads).

@meksor meksor requested review from glatterf42 and pmussak February 9, 2024 15:37
glatterf42
glatterf42 requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, but looks good otherwise.

glatterf42
glatterf42 reviewed Feb 12, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@glatterf42 glatterf42 added the enhancement New feature or request label Feb 13, 2024
glatterf42
glatterf42 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks :)

@meksor meksor merged commit 4b33dc6 into main Feb 13, 2024
7 checks passed
@meksor meksor deleted the feature/docker-integration branch February 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glatterf42 glatterf42 glatterf42 approved these changes

@pmussak pmussak Awaiting requested review from pmussak

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meksor @glatterf42