Merge pull request #237 from gjaekel/gjaekel-issue225

Update FeedbackServlet.java
igniterealtime · Jan 31, 2021 · b04c8c5 · b04c8c5
2 parents cdf56ca + 0ece85c
commit b04c8c5
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/web/src/main/java/org/jivesoftware/openfire/plugin/ofmeet/FeedbackServlet.java b/web/src/main/java/org/jivesoftware/openfire/plugin/ofmeet/FeedbackServlet.java
@@ -1,3 +1,4 @@
+root@evalfire0 /opt/.opt/openfire/_src/git/openfire-pade-plugin-master # expand ./web/src/main/java/org/jivesoftware/openfire/plugin/ofmeet/FeedbackServlet.java
 package org.jivesoftware.openfire.plugin.ofmeet;
 
 import org.jivesoftware.util.JiveGlobals;
@@ -106,12 +107,17 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
             }
             LOG.info(feedback.toString());
             final String comment = feedback.optString("comment","");
-            securityAuditManager.logEvent
-            (
-                feedback.getString("callStatsUserName")
-                , "pade feedback A/V-rating: " + feedback.optString("audio","-") +"/" + feedback.optString("video","-") + ( ! comment.isEmpty() ? " +" + Integer.toString(comment.length()) + "c" : "" )
-                , comment
-            );
+            final String audioRating = feedback.optString("audio","-");
+            final String videoRating = feedback.optString("video","-");
+            if ( ! audioRating.equals("-") || ! videoRating.equals("-") || ! comment.isEmpty() )
+            {
+                securityAuditManager.logEvent
+                (
+                    feedback.getString("callStatsUserName")
+                    , "pade feedback A/V-rating: " + audioRating +"/" + videoRating + ( ! comment.isEmpty() ? ", comment: " + Integer.toString(comment.length()) + "c" : "" )
+                    , comment
+                );
+            }
         }
         catch (final Exception e)
         {