Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/239 settings not saved #260

Conversation

BartlomiejWlodarczak
Copy link

Description

Hi, i noticed the same buggy behavior of a few settings in iGlance and decided to take a look myself and fix it. It seems someone else spotted it too and opened an issue (link below).

Bug was simple to track down. Here's a summary:

  • Battery percentage/time left setting was wrongly getting another boolean value.
  • Autostart on Boot was saved correctly, but decoded as string hence always was false at the time of launch.

Related Issue

#239

@BartlomiejWlodarczak BartlomiejWlodarczak changed the base branch from master to development May 30, 2021 22:06
Copy link
Member

@D0miH D0miH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top 👍

@D0miH
Copy link
Member

D0miH commented Jun 5, 2021

Hey @BartlomiejWlodarczak,
thanks so much for your PR.

@D0miH D0miH merged commit 875d9d2 into iglance:development Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants