Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Big Sur menu bar font color #251

Conversation

MarlonJD
Copy link

@MarlonJD MarlonJD commented Dec 7, 2020

On light theme, there was an issue about the font color. On light theme black color is really bad on Big Sur.

Description

There was an issue about the font color when light theme was activated. So I changed font color and graph border color to white on light theme only on Big Sur.

So I changed these codes and I tested on my Mac.

Related Issue

#250
Before:
image
After:
image

@D0miH
Copy link
Member

D0miH commented Dec 17, 2020

As far as I can see you changed the font color to white if the current operating system is Big Sur, right?
After some research I found out that the font color in the menu bar depends on the wallpaper of the desktop. Meaning that if the wallpaper is dark, the menu bar theme gets light to have higher contrast. When the wallpaper is light, the theme of the menu bar is going to be dark.

I'm afraid just setting the font color to white if the current operating system is Big Sur won't do it.

I think we would have to check if the theme change-callback was called without an actual change of the applied theme (As mentioned in https://stackoverflow.com/a/64525038).
So I think the problem you experience is described in issue #229.
If you want you can change the code and try if you can detect the menu-bar-theme-change by observing the theme value in the callback function.

@D0miH D0miH changed the title Fix font color on light theme Fix Big Sur menu bar font color Dec 17, 2020
@MarlonJD
Copy link
Author

Hmm i think you're right. I didn't realize wallpaper related menu bar colour. Maybe we can create button on dark or light font color on settings. But I'll research about the changing it automatically

@D0miH D0miH added the WIP Work in Progress label Dec 27, 2020
@naveenyadav15
Copy link

naveenyadav15 commented Feb 22, 2021

This is the same issue I'm facing. Please update the code or give an option in the setting to change the color.
I faced it when using safari.

@dstamen
Copy link

dstamen commented Jun 3, 2021

any chance to commit/merge this?

@MarlonJD
Copy link
Author

MarlonJD commented Jun 3, 2021

This is not production ready, macos bar background is changing with the wallpaper, so I couldn't fix the issue yet. If you got idea about the issue please inform

@MarlonJD MarlonJD closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants