Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property for security protocol/version #1465

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add property for security protocol/version #1465

merged 2 commits into from
Jan 30, 2024

Conversation

tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Jan 29, 2024

No description provided.

@tfpauly tfpauly added the API label Jan 29, 2024
@tfpauly tfpauly requested review from britram and mwelzl January 29, 2024 16:32
@tfpauly tfpauly self-assigned this Jan 29, 2024
zaheduzzaman
zaheduzzaman reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@zaheduzzaman zaheduzzaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mwelzl
mwelzl requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change suggested (see also the comment by @mirjak )

draft-ietf-taps-interface.md Outdated Show resolved Hide resolved
mwelzl
mwelzl approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tfpauly tfpauly merged commit e6222cd into master Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirjak mirjak mirjak left review comments

@zaheduzzaman zaheduzzaman zaheduzzaman left review comments

@mwelzl mwelzl mwelzl approved these changes

@britram britram britram approved these changes

Assignees

@tfpauly tfpauly

Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tfpauly @britram @zaheduzzaman @mwelzl @mirjak