Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property names aren't case sensitive #1402

Closed
wants to merge 1 commit into from
Closed

Property names aren't case sensitive #1402

wants to merge 1 commit into from

Conversation

mwelzl
Copy link
Contributor

@mwelzl mwelzl commented Oct 10, 2023

Closes #1338

@mwelzl mwelzl requested review from gorryfair and philsbln October 10, 2023 13:05
@mwelzl mwelzl added the API label Oct 10, 2023
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 10, 2023

Note, before merging and therewith closing #1338, let's make sure we agree about the discussion in #1338.

gorryfair
gorryfair approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I understood!

philsbln
philsbln approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@philsbln philsbln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to make that explicit

philsbln added a commit that referenced this pull request Oct 11, 2023
@philsbln
Make Transport Property Names more strict (and case-insenstitive)
5b09539 
alternative to #1402
closes #1338
@philsbln philsbln mentioned this pull request Oct 11, 2023
Merged
@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 11, 2023

Closing this because we have #1404. Better to discuss there and finish this off.

@mwelzl mwelzl closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsbln philsbln philsbln approved these changes

@gorryfair gorryfair gorryfair approved these changes

@tfpauly tfpauly tfpauly approved these changes

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property names
4 participants
@mwelzl @tfpauly @gorryfair @philsbln