-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates #62
base: master
Are you sure you want to change the base?
Some updates #62
Conversation
who command to get online users all command to broadcast to all online users
Thanks @yamaha252! Looks like an awesome contribution. Since it is pretty massive it will take me some time to review it. Hopefully I can get to it this week. |
fix for old mobile devices
Removed limit to old node/npm. Updated some dependencies based on pull request idoco#64
@idoco: Any possibility to get this one accepted? If you want I can review/test it for you. I really love your product but seems a lot of the files are 2years old so I'm wondering how the support is. I can understand that you do not have a lot of time available, but I'm willing to help if needed. |
Hi @Bramzor, sorry for the slow response. I really appreciate you taking the time to contribute to this project; this is never obvious. I'd really love to accept this change, the problem is that never had enough time to test it. The hosted version of Intergram is embedded in hundreds for websites and is being loaded by millions of users every week! My biggest concern is harming any of these hosting websites, and this is why I take merging pull requests so seriously. Intergram is sort of my weekend project, but lately, I didn't have much time for it. I hope to get to this sometime this month, but in the meantime, the best thing I can offer is to host your version. I hope you understand. |
Hi @idoco, I understand your concerns that you do not want to break things. Maybe it can be a solution to start branches and different versions so it wouldn't change anything for people currently using it but a beta branch would still be able to progress. |
Guys, we use this changes on production all this year and the service was fully tested of our qa team. Don't worry to try them. |
Remove the old engines (node version) limitation
fix all, ban, unban commands for /<command>@botName calls
any chance on this getting merged soon soon ? |
hopw someday we will see it in a master |
Hi yamaha252, I'm loving your updates done and thank you for them. I was wondering if you were able to provide some advice on how I might be able to enable sending images and small attachments? It seems like you have a lot more experience and knowledge in this space and will appreciate any advice you have, I'm happy to contribute if I manage to include that functionality :) |
@yoweeking It should be not so difficult, telegram has a good api to send files. It's possible to upload directly to telegram servers or using your own server to keep files and send it to the bot as a link. |
Hello! Thanks for amazing service!
I did some improvements for it and I wanted to send a few pull requests for different features but now there are a lot of changes and it's too difficult to split they :-\
Changes:
--
/all [any_text]
- Send message to all online users--
/who
- Get users list who are online now--
/online
- Set online status for the chat. Widget is shown for users--
/offline
- Set offline status for the chat. Widget is hidden for users--
/ban [name]
- Ban user--
/unban [name]
- Unban userhuman-readable-ids
package)The changes should be additional tested. Especially on mobile devices.
TODO:
lowdb
? (chat states, offline messages)new message
indicator.