Fixed thumb size calculation when track height is not equal to content height #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idiotWu
reviewed
Sep 17, 2021
| @@ -72,6 +72,7 @@ export class ScrollbarTrack implements I.ScrollbarTrack { | |||
| display: pageSize <= containerSize ? 'none' : 'block', | |||
| }); | |||
|
|
|||
| this.thumb.update(scrollOffset, containerSize, pageSize); | |||
| const trackHeightOffset = (this.direction === TrackDirection.Y ? this.element.offsetHeight : this.element.offsetWidth) - containerSize; | |||
There was a problem hiding this comment.
For cases when scrollbar height/width is not equal to scrollable area size, e.g.
There was a problem hiding this comment.
Then I think the thumb size would be trackSize / pageSize in that case, so leaving the 3rd parameter as pageSize is enough (the next line). Have you tested it?
PS: and the 2nd parameter should be the track's size
|
Let's leave this PR open as it's not the expected behavior of a standard scrollbar. I'll consider whether to merge it or not in the next major release. |
|
Any updates? It should be expected behavior that one wants to adjust the height of the track and scrollbar... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes