Add subcube loading #320
Open
Add subcube loading #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a triplet set or configuration that is not there.
…Issue with toggle and input field not allowing interaction.
…to the other interactables of the subset UI.� * Added subset loading of fits files to VolumeDataSet. * Added subset loading of mask to fits_reader c++ library.
* Fix an issue where the UI subset assumed zero-indexed. * Fix that the smallest dimension was two, it's now one. * Fix that the UI allowed max to be less than min and vice versa.
* Cell outline is now broken, need to fix.
Pietersielie
added
enhancement
|
Add crop select and values to the sub cubes. |
* Corrected the subcube offset to not happen. * Added documentation for functions that I knew the purpose of.
* Merging main in to get debug log and test a few things.
* An unrelated issue when painting on a cube with no mask loaded is
now apparent. VolumeDataSetRenderer:502 is true, but still get error
as if it wasn't.
CosmicElysium
requested changes
Mar 3, 2024
Comment on lines
203
to
214
| // savePopup.transform.SetParent(this.transform.parent, false); | ||
| // savePopup.transform.localPosition = this.transform.localPosition; | ||
| // savePopup.transform.localRotation = this.transform.localRotation; | ||
| // savePopup.transform.localScale = this.transform.localScale; | ||
|
|
||
| // savePopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Cancel").GetComponent<Button>().onClick.RemoveAllListeners(); | ||
| // savePopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Overwrite").GetComponent<Button>().onClick.RemoveAllListeners(); | ||
| // savePopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("NewFile").GetComponent<Button>().onClick.RemoveAllListeners(); | ||
|
|
||
| // savePopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Cancel").GetComponent<Button>().onClick.AddListener(SaveCancel); | ||
| // savePopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Overwrite").GetComponent<Button>().onClick.AddListener(SaveOverwriteMask); | ||
| // savePopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("NewFile").GetComponent<Button>().onClick.AddListener(SaveNewMask); |
There was a problem hiding this comment.
Should we just remove these lines?
Comment on lines
329
to
340
| // exportPopup.transform.SetParent(this.transform.parent, false); | ||
| // exportPopup.transform.localPosition = this.transform.localPosition; | ||
| // exportPopup.transform.localRotation = this.transform.localRotation; | ||
| // exportPopup.transform.localScale = this.transform.localScale; | ||
|
|
||
| // exportPopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Cancel").GetComponent<Button>().onClick.RemoveAllListeners(); | ||
| // exportPopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("SubCube").GetComponent<Button>().onClick.RemoveAllListeners(); | ||
| // exportPopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Mask").GetComponent<Button>().onClick.RemoveAllListeners(); | ||
|
|
||
| // exportPopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Cancel").GetComponent<Button>().onClick.AddListener(ExportCancel); | ||
| // exportPopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("SubCube").GetComponent<Button>().onClick.AddListener(SaveSubCube); | ||
| // exportPopup.transform.Find("Content").gameObject.transform.Find("FirstRow").gameObject.transform.Find("Mask").GetComponent<Button>().onClick.AddListener(SaveMask); |
There was a problem hiding this comment.
Remove these as well?
| return -1; | ||
| } | ||
| std::stringstream debug; | ||
| debug << "Closing fitsfile " << fptr->Fptr->filename << "."; |
There was a problem hiding this comment.
In the long time I have used cfitsio, I have never thought about using a member of Fptr XD
There was a problem hiding this comment.
Excellent! Your changes will add a bit more robustness to the fits reading/writing.
This was
linked to
issues
Mar 12, 2024
* Read as many slices as fit in long::max() pixels.
…o/idia_unity_vr into cilliers/fix-issue-307
* Fix issue with loading cubes with NAXES>3 in the new method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #307 and resolve #318.