making sure that media on the development environment is not served from outside the environment. #4
Conversation
…llectstatic doesn't bother us with a prompt
media and static directories that people will need.
allowing users to hit 500 error when tables in intermediate state.
| MEDIA_URL = '/media/' | ||
|
|
||
| STATIC_ROOT = PROJECT_DIR.child('static_root') | ||
| STATIC_ROOT = PROJECT_DIR.child('static-root') |
There was a problem hiding this comment.
Why the change from underscore to hyphen here?
There was a problem hiding this comment.
because it looks neater. Easier to read.
There was a problem hiding this comment.
In this case, I think legibility is a matter of personal preference. I use underscores, not dashes. -1 on this change.
|
I like some of the practical bits in this pull request, but there are parts I don't grok. Check out the above comments on lines of code. |
|
Updated. What do you think overall? |
|
Added comments above for each of the changes. Overall I like the changes, save those I've explicitly -1'd. Once everything is sorted out with the various comments I've made, this will get merged -- thank you for your work! While you're at it, add an Authors section at the bottom of readme with your name in it. |
|
You've kicked the ball this far; I don't want to appear unappreciative. If you like, I can pull these commits to a branch, make the desired cleanup, and merge it myself. |
|
if you'd like to cherry pick code, go ahead. Otherwise i can fix it up and you can pull. your choice. |
|
NOT CLOSED! NOT CLOSED! DAMNIT TOUCHPAD! |
| @@ -1,6 +1,9 @@ | |||
| from __future__ import absolute_import | |||
| from .base import * | |||
|
|
|||
| MEDIA_ROOT = PROJECT_DIR.parent.child('data') | |||
There was a problem hiding this comment.
If we're adding this line here anyways, might as well do it right: the value for MEDIA_ROOT should be config['core']['data_directory'], which requires importing config a bit further up in the file.
|
Well, gonna pull an executive lazy and let you make the changes; thanks again for your work. :) |
~ settings: use epio settings to set correct media paths; bring development media path inside app directory.
~ structure: auto create media, static and static_root using stub .gitignores
~ fabfile: use --noinput on collectstatic to remove prompt
~ fabfile: use file to make sure fabfile can be called from anywhere and still initiate epio client from correct directory.