Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduled notifications and announcements #41

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Scheduled notifications and announcements #41

merged 8 commits into from
Jun 14, 2024

Conversation

ice-myles
Copy link
Contributor

Changed the translation files format (removed dir and files from dir were moved to 1 file for each notification type).

@ice-myles ice-myles added the enhancement New feature or request label Jun 4, 2024
@ice-myles ice-myles self-assigned this Jun 4, 2024
@ice-myles ice-myles requested a review from a team as a code owner June 4, 2024 12:09
@ice-myles ice-myles enabled auto-merge (squash) June 4, 2024 12:09
ice-ares
ice-ares requested changes Jun 6, 2024
View reviewed changes
cmd/husky-bark/api/docs.go Outdated Show resolved Hide resolved
notifications/announcement_weekly_stats.go Outdated Show resolved Hide resolved
notifications/contract.go Outdated Show resolved Hide resolved
notifications/contract.go Outdated Show resolved Hide resolved
notifications/notification_invite_friend.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
ice-ares
ice-ares reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@ice-ares ice-ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check each notification and see how it would work on staging, how frequent, etc

notifications/announcement_weekly_stats.go Outdated Show resolved Hide resolved
notifications/notification_invite_friend.go Outdated Show resolved Hide resolved
notifications/notification_invite_friend.go Outdated Show resolved Hide resolved
notifications/notification_invite_friend.go Show resolved Hide resolved
notifications/notifications.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
notifications/scheduler.go Outdated Show resolved Hide resolved
notifications/scheduler_announcements.go Show resolved Hide resolved
notifications/scheduler_notifications.go Show resolved Hide resolved
@ice-myles ice-myles force-pushed the feature/scheduled-notifications branch from bfa2537 to 3223db6 Compare June 12, 2024 12:33
@ice-myles ice-myles force-pushed the feature/scheduled-notifications branch from 58c8a7a to 565e385 Compare June 12, 2024 16:31
@ice-ares ice-ares disabled auto-merge June 14, 2024 16:37
@ice-ares ice-ares merged commit bcaaa05 into master Jun 14, 2024
19 checks passed
@ice-ares ice-ares deleted the feature/scheduled-notifications branch June 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice-ares ice-ares ice-ares requested changes

Assignees

@ice-myles ice-myles

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ice-myles @ice-ares