Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix news sort #39

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix news sort #39

merged 2 commits into from
Dec 7, 2023

Conversation

ice-cronus
Copy link
Contributor

Here are 2 issues:

  1. due to different languages were uploaded in different times, sort by created at was messed (if language is not English), now we're using english upload date as reference
  2. sync viewed column (and sorting based on it) with GetUnreadCount, which takes into account FE createdAfter flag (but sorting were not before)

@ice-cronus ice-cronus requested a review from a team as a code owner December 7, 2023 09:25
@ice-cronus ice-cronus self-assigned this Dec 7, 2023
@ice-cronus ice-cronus added the bug Something isn't working label Dec 7, 2023
@ice-ares
Copy link
Contributor

ice-ares commented Dec 7, 2023

I see only lint fixes, where’s the actual fix?

@ice-cronus
Copy link
Contributor Author

Here, there are 2 commits: c3ede81

@ice-ares ice-ares merged commit b6d31ce into master Dec 7, 2023
19 checks passed
@ice-ares ice-ares deleted the bugfix/news_order_fix branch December 7, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ice-cronus ice-cronus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ice-cronus @ice-ares