-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search improvements #33
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I did notice code duplication in the searchInvestigations
, searchDatasets
and searchDatafiles
methods in the ICAT
class which could probably be avoided by refactoring the common logic into a new method that these methods can call.
Yeah you're right, a lot of the JSON building could be refactored. I might leave the old |
This looks much nicer now, thank you for making the changes @patrick-austin. I forgot to say initially but, yes, the deprecated methods do not need to be updated. |
Add support for new Lucene based free text search functionality:
searchInvestigations
accepting additional parameters such as facets and sortingsearchInvestigations
accepting additional parameters such as facets and sortingsearchInvestigations
accepting additional parameters such as facets and sortinglucenePopulate
so that the client call and resultant behaviour is unchanged, but it gives the parameters that icat.server now expectsNote that existing methods for searching are unchanged (these have less features and only return ids rather than full documents).