This repository has been archived by the owner on Dec 1, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
add option.exclude #9
Open
SergioCrisostomo
wants to merge
4
commits into
ibolmo:master
Choose a base branch
from
SergioCrisostomo:exclude
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c2aa2b0
add option.exclude
SergioCrisostomo b65dd22
add example, DRY regex, fix indentation
SergioCrisostomo d41f086
Adds additional tests and support for root-level only/exclude instruc…
anutron 7d15847
Merge pull request #1 from anutron/master
SergioCrisostomo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,6 +143,11 @@ grunt.initConfig({ | |
}); | ||
``` | ||
|
||
#### options.exclude | ||
Type: `Array` | ||
|
||
The specific dependencies packages to exclude from the compilation. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You might include an example; the fact that it can take wild cards is non-obvious. |
||
### Other Usage Examples | ||
|
||
#### Default Options | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,6 +165,18 @@ module.exports = function(grunt) { | |
// load each component into the buffer list | ||
(only ? toArray(only) : set).forEach(loadComponent); | ||
|
||
// remove unwanted dependencies | ||
if (options.exclude){ | ||
var toExclude = toArray(options.exclude); | ||
buffer = buffer.filter(function(def){ | ||
var shouldKeep = toExclude.filter(function(dependency){ | ||
var match = dependency.match(/([^\*]+)/); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not necessary, but I feel like this matcher should be a method reused elsewhere. |
||
return match ? def.key.indexOf(match[1]) != 0 : true; | ||
}); | ||
return shouldKeep.length; | ||
}); | ||
} | ||
|
||
// convert the buffer into the actual source | ||
buffer = buffer.map(function(def){ return def.source; }).join(options.separator); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/* | ||
--- | ||
|
||
name: B part of ProjectA | ||
|
||
description: ProjectB, extending ProjectA | ||
|
||
requires: [ProjectA/ProjectA] | ||
|
||
provides: ProjectB | ||
|
||
... | ||
*/ | ||
|
||
var projectB = function(){ | ||
return [projectA.name].concat('ProjectB'); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation